Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add overloading to contract functions. #28

Merged
merged 14 commits into from
Nov 10, 2023
Merged

Add overloading to contract functions. #28

merged 14 commits into from
Nov 10, 2023

Conversation

sentilesdal
Copy link
Contributor

@sentilesdal sentilesdal commented Nov 10, 2023 •
edited
Loading

Fixes #7

  • add multimethod package
  • add function for getting output names n variables
  • add overloaded method capability
  • split up contract template file
  • remove setup_templates() function
  • let black handle all formatting
  • render with split files
  • fix things
  • add snapshot testing

@sentilesdal sentilesdal mentioned this pull request Nov 10, 2023
Closed
@sentilesdal sentilesdal force-pushed the matt-overload-types branch 2 times, most recently from 55a03cd to 199cdb7 Compare November 10, 2023 15:27
@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (1c500d5) 81.47% compared to head (e604fd8) 86.78%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
+ Coverage   81.47%   86.78%   +5.30%     
==========================================
  Files          13       10       -3     
  Lines         394      348      -46     
==========================================
- Hits          321      302      -19     
+ Misses         73       46      -27
Flag Coverage Δ
unittests 86.78% <98.14%> (+5.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pypechain/main.py 86.66% <ø> (ø)
pypechain/render/contract.py 97.56% <100.00%> (+40.89%) ⬆️
pypechain/render/main.py 100.00% <100.00%> (ø)
pypechain/render/types.py 100.00% <100.00%> (ø)
pypechain/utilities/format.py 77.77% <100.00%> (+7.77%) ⬆️
pypechain/utilities/templates.py 100.00% <100.00%> (ø)
pypechain/utilities/abi.py 84.61% <88.88%> (+2.68%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sentilesdal sentilesdal merged commit 00c2e03 into main Nov 10, 2023
3 checks passed
@sentilesdal sentilesdal deleted the matt-overload-types branch November 10, 2023 18:34
@dpaiton dpaiton mentioned this pull request Nov 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix overloading bug
2 participants
@sentilesdal @codecov-commenter